refactor: use last_moved_timestamp instead of scanning edit_history(#1397) #2058
+65
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace inefficient edit_history scanning with direct last_moved_timestamp lookup to improve performance when determining when items were last moved. Fixes zulip#1397
chrisbobbe
reviewed
Jan 2, 2026
Collaborator
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
One comment below, from a quick skim. Also, this PR needs tests.
lib/api/model/model.dart
Outdated
Comment on lines
1184
to
1194
| // Old server: need to scan edit_history to determine if content was edited. | ||
| final editHistory = json['edit_history'] as List<dynamic>?; | ||
| if (editHistory == null) return lastEditTimestamp; | ||
|
|
||
| // Find the timestamp of the first content edit. | ||
| for (final entry in editHistory) { | ||
| if (entry['prev_content'] != null) { | ||
| return entry['timestamp'] as int?; | ||
| } | ||
| } | ||
| return null; |
Collaborator
There was a problem hiding this comment.
This is meant to replace the history-scanning code in MessageEditState._readFromMessage, right? But that code is still present, untouched.
Author
There was a problem hiding this comment.
Yes, but in the issue I observed other contributor plan was to use editHistory too.
But after you point out this I checked is it neccessary to keep that, but I conclude to that it is not necessary and everything is working correctly on the new server.
@chrisbobbe now could you check ?
Author
|
Hi @chrisbobbe, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace inefficient edit_history scanning with direct last_moved_timestamp lookup to improve performance when determining when items were last moved.
Fixes #1397